@Test(dataProvider = "fixtures")
public void testGetterAttributeInfo(
String attribute, boolean isIs, Object[] values, Class<?> clazz) throws Exception {
String methodName = "set" + attribute.replace(".", "");
for (T t : objects) {
String attributeName = toFeatureName(attribute, t);
SimpleInterface simpleInterface = toSimpleInterface(t);
Method setter = getMethod(simpleInterface.getClass(), methodName, clazz);
MBeanInfo info = getMBeanInfo(t);
MBeanAttributeInfo attributeInfo = getAttributeInfo(info, attributeName);
assertNotNull(attributeInfo, "AttributeInfo for " + attributeName);
assertEquals(attributeInfo.getName(), attributeName, "Attribute Name for " + attributeName);
assertEquals(
attributeInfo.getType(),
setter.getParameterTypes()[0].getName(),
"Attribute type for " + attributeName);
assertEquals(attributeInfo.isIs(), isIs, "Attribute isIs for " + attributeName);
assertTrue(attributeInfo.isReadable(), "Attribute Readable for " + attributeName);
assertFalse(attributeInfo.isWritable(), "Attribute Writable for " + attributeName);
}
}
private MBeanAttributeInfo[] createMBeanAttributeInfo(
MBeanMetaData metadata, MBeanDescription description) {
Logger logger = getLogger();
HashMap attributes = new HashMap();
HashMap getterNames = new HashMap();
Method[] methods = metadata.management.getMethods();
for (int j = 0; j < methods.length; ++j) {
Method method = methods[j];
if (Utils.isAttributeGetter(method)) {
String name = method.getName();
boolean isIs = name.startsWith("is");
String attribute = null;
if (isIs) attribute = name.substring(2);
else attribute = name.substring(3);
String descr = description == null ? null : description.getAttributeDescription(attribute);
MBeanAttributeInfo info = (MBeanAttributeInfo) attributes.get(attribute);
if (info != null) {
// JMX spec does not allow overloading attributes.
// If an attribute with the same name already exists the MBean is not compliant
if (!info.getType().equals(method.getReturnType().getName())) {
if (logger.isEnabledFor(Logger.DEBUG))
logger.debug("MBean is not compliant: has overloaded attribute " + attribute);
return null;
} else {
// They return the same value,
if (getterNames.get(name) != null) {
// This is the case of an attribute being present in multiple interfaces
// Ignore all but the first, since they resolve to the same method anyways
continue;
}
// there is a chance that one is a get-getter and one is a is-getter
// for a boolean attribute. In this case, the MBean is not compliant.
if (info.isReadable()) {
if (logger.isEnabledFor(Logger.DEBUG))
logger.debug("MBean is not compliant: has overloaded attribute " + attribute);
return null;
}
// MBeanAttributeInfo is already present due to a setter method, just update its
// readability
info =
new MBeanAttributeInfo(
attribute,
info.getType(),
info.getDescription(),
true,
info.isWritable(),
isIs);
}
} else {
info =
new MBeanAttributeInfo(
attribute, method.getReturnType().getName(), descr, true, false, isIs);
}
// Replace if exists
attributes.put(attribute, info);
getterNames.put(name, method);
} else if (Utils.isAttributeSetter(method)) {
String name = method.getName();
String attribute = name.substring(3);
String descr = description == null ? null : description.getAttributeDescription(attribute);
MBeanAttributeInfo info = (MBeanAttributeInfo) attributes.get(attribute);
if (info != null) {
// JMX spec does not allow overloading attributes.
// If an attribute with the same name already exists the MBean is not compliant
if (!info.getType().equals(method.getParameterTypes()[0].getName())) {
if (logger.isEnabledFor(Logger.DEBUG))
logger.debug("MBean is not compliant: has overloaded attribute " + attribute);
return null;
} else {
// MBeanAttributeInfo is already present due to a getter method, just update its
// writability
info =
new MBeanAttributeInfo(
info.getName(),
info.getType(),
info.getDescription(),
info.isReadable(),
true,
info.isIs());
}
} else {
info =
new MBeanAttributeInfo(
attribute, method.getParameterTypes()[0].getName(), descr, false, true, false);
}
// Replace if exists
attributes.put(attribute, info);
}
}
return (MBeanAttributeInfo[])
attributes.values().toArray(new MBeanAttributeInfo[attributes.size()]);
}
