@Override
public Object visit(ASTVariableDeclarator node, Object data) {
// Search Catch stmt nodes for variable used to store improperly created
// throwable or exception
try {
if (node.hasDescendantMatchingXPath(FIND_THROWABLE_INSTANCE)) {
String variableName = node.jjtGetChild(0).getImage(); // VariableDeclatorId
ASTCatchStatement catchStmt = node.getFirstParentOfType(ASTCatchStatement.class);
while (catchStmt != null) {
List<Node> violations =
catchStmt.findChildNodesWithXPath(
"//Expression/PrimaryExpression/PrimaryPrefix/Name[@Image = '"
+ variableName
+ "']");
if (!violations.isEmpty()) {
// If, after this allocation, the 'initCause' method is
// called, and the ex passed
// this is not a violation
if (!useInitCause(violations.get(0), catchStmt)) {
addViolation(data, node);
}
}
// check ASTCatchStatement higher up
catchStmt = catchStmt.getFirstParentOfType(ASTCatchStatement.class);
}
}
return super.visit(node, data);
} catch (JaxenException e) {
// XPath is valid, this should never happens...
throw new IllegalStateException(e);
}
}
private boolean useInitCause(Node node, ASTCatchStatement catchStmt) {
// In case of NPE...
if (node != null && node.getImage() != null) {
return catchStmt.hasDescendantMatchingXPath(
"./Block/BlockStatement/Statement/StatementExpression/PrimaryExpression/PrimaryPrefix/Name[@Image = '"
+ node.getImage()
+ ".initCause']");
}
return false;
}
@Override
public Object visit(ASTCatchStatement catchStmt, Object data) {
String target =
catchStmt
.jjtGetChild(0)
.findChildrenOfType(ASTVariableDeclaratorId.class)
.get(0)
.getImage();
// Inspect all the throw stmt inside the catch stmt
List<ASTThrowStatement> lstThrowStatements =
catchStmt.findDescendantsOfType(ASTThrowStatement.class);
for (ASTThrowStatement throwStatement : lstThrowStatements) {
Node n = throwStatement.jjtGetChild(0).jjtGetChild(0);
if (n instanceof ASTCastExpression) {
ASTPrimaryExpression expr = (ASTPrimaryExpression) n.jjtGetChild(1);
if (expr.jjtGetNumChildren() > 1 && expr.jjtGetChild(1) instanceof ASTPrimaryPrefix) {
RuleContext ctx = (RuleContext) data;
addViolation(ctx, throwStatement);
}
continue;
}
// Retrieve all argument for the throw exception (to see if the
// original exception is preserved)
ASTArgumentList args = throwStatement.getFirstDescendantOfType(ASTArgumentList.class);
if (args != null) {
Node parent = args.jjtGetParent().jjtGetParent();
if (parent instanceof ASTAllocationExpression) {
// maybe it is used inside a anonymous class
ck(data, target, throwStatement, parent);
} else {
ck(data, target, throwStatement, args);
}
} else {
Node child = throwStatement.jjtGetChild(0);
while (child != null && child.jjtGetNumChildren() > 0 && !(child instanceof ASTName)) {
child = child.jjtGetChild(0);
}
if (child != null) {
if (child instanceof ASTName
&& !target.equals(child.getImage())
&& !child.hasImageEqualTo(target + FILL_IN_STACKTRACE)) {
Map<VariableNameDeclaration, List<NameOccurrence>> vars =
((ASTName) child).getScope().getDeclarations(VariableNameDeclaration.class);
for (Map.Entry<VariableNameDeclaration, List<NameOccurrence>> entry : vars.entrySet()) {
VariableNameDeclaration decl = entry.getKey();
List<NameOccurrence> occurrences = entry.getValue();
if (decl.getImage().equals(child.getImage())) {
if (!isInitCauseCalled(target, occurrences)) {
args =
decl.getNode().jjtGetParent().getFirstDescendantOfType(ASTArgumentList.class);
if (args != null) {
ck(data, target, throwStatement, args);
}
}
}
}
} else if (child instanceof ASTClassOrInterfaceType) {
addViolation(data, throwStatement);
}
}
}
}
return super.visit(catchStmt, data);
}
