private void handleBranchingInstruction(
ProblemsHolder holder,
StandardInstructionVisitor visitor,
Set<Instruction> trueSet,
Set<Instruction> falseSet,
HashSet<PsiElement> reportedAnchors,
BranchingInstruction instruction,
final boolean onTheFly) {
PsiElement psiAnchor = instruction.getPsiAnchor();
boolean underBinary = isAtRHSOfBooleanAnd(psiAnchor);
if (instruction instanceof InstanceofInstruction
&& visitor.isInstanceofRedundant((InstanceofInstruction) instruction)) {
if (visitor.canBeNull((BinopInstruction) instruction)) {
holder.registerProblem(
psiAnchor,
InspectionsBundle.message("dataflow.message.redundant.instanceof"),
new RedundantInstanceofFix());
} else {
final LocalQuickFix localQuickFix = createSimplifyBooleanExpressionFix(psiAnchor, true);
holder.registerProblem(
psiAnchor,
InspectionsBundle.message(
underBinary
? "dataflow.message.constant.condition.when.reached"
: "dataflow.message.constant.condition",
Boolean.toString(true)),
localQuickFix == null ? null : new LocalQuickFix[] {localQuickFix});
}
} else if (psiAnchor instanceof PsiSwitchLabelStatement) {
if (falseSet.contains(instruction)) {
holder.registerProblem(
psiAnchor, InspectionsBundle.message("dataflow.message.unreachable.switch.label"));
}
} else if (psiAnchor != null
&& !reportedAnchors.contains(psiAnchor)
&& !isFlagCheck(psiAnchor)) {
boolean evaluatesToTrue = trueSet.contains(instruction);
final PsiElement parent = psiAnchor.getParent();
if (parent instanceof PsiAssignmentExpression
&& ((PsiAssignmentExpression) parent).getLExpression() == psiAnchor) {
holder.registerProblem(
psiAnchor,
InspectionsBundle.message(
"dataflow.message.pointless.assignment.expression",
Boolean.toString(evaluatesToTrue)),
createConditionalAssignmentFixes(
evaluatesToTrue, (PsiAssignmentExpression) parent, onTheFly));
} else if (!skipReportingConstantCondition(visitor, psiAnchor, evaluatesToTrue)) {
final LocalQuickFix fix = createSimplifyBooleanExpressionFix(psiAnchor, evaluatesToTrue);
String message =
InspectionsBundle.message(
underBinary
? "dataflow.message.constant.condition.when.reached"
: "dataflow.message.constant.condition",
Boolean.toString(evaluatesToTrue));
holder.registerProblem(psiAnchor, message, fix == null ? null : new LocalQuickFix[] {fix});
}
reportedAnchors.add(psiAnchor);
}
}
private static boolean hasNonInvertedCalls(final RefMethod refMethod) {
final Boolean alwaysInverted = refMethod.getUserData(ALWAYS_INVERTED);
if (alwaysInverted == null) return true;
if (refMethod.isExternalOverride()) return true;
if (refMethod.isReferenced() && !alwaysInverted.booleanValue()) return true;
final Collection<RefMethod> superMethods = refMethod.getSuperMethods();
for (RefMethod superMethod : superMethods) {
if (hasNonInvertedCalls(superMethod)) return true;
}
return false;
}
private synchronized void writeOutput(
@NotNull final CommonProblemDescriptor[] descriptions, @NotNull RefEntity refElement) {
final Element parentNode = new Element(InspectionsBundle.message("inspection.problems"));
exportResults(descriptions, refElement, parentNode);
final List list = parentNode.getChildren();
@NonNls final String ext = ".xml";
final String fileName = ourOutputPath + File.separator + myToolWrapper.getShortName() + ext;
final PathMacroManager pathMacroManager =
PathMacroManager.getInstance(getContext().getProject());
PrintWriter printWriter = null;
try {
new File(ourOutputPath).mkdirs();
final File file = new File(fileName);
final CharArrayWriter writer = new CharArrayWriter();
if (!file.exists()) {
writer
.append("<")
.append(InspectionsBundle.message("inspection.problems"))
.append(" " + GlobalInspectionContextBase.LOCAL_TOOL_ATTRIBUTE + "=\"")
.append(Boolean.toString(myToolWrapper instanceof LocalInspectionToolWrapper))
.append("\">\n");
}
for (Object o : list) {
final Element element = (Element) o;
pathMacroManager.collapsePaths(element);
JDOMUtil.writeElement(element, writer, "\n");
}
printWriter =
new PrintWriter(
new BufferedWriter(
new OutputStreamWriter(
new FileOutputStream(fileName, true), CharsetToolkit.UTF8_CHARSET)));
printWriter.append("\n");
printWriter.append(writer.toString());
} catch (IOException e) {
LOG.error(e);
} finally {
if (printWriter != null) {
printWriter.close();
}
}
}
private static boolean calcNeedUpdateOnTyping(
@Nullable Boolean needsUpdateOnTyping, HighlightInfoType type) {
if (needsUpdateOnTyping != null) return needsUpdateOnTyping.booleanValue();
if (type == HighlightInfoType.TODO) return false;
if (type == HighlightInfoType.LOCAL_VARIABLE) return false;
if (type == HighlightInfoType.INSTANCE_FIELD) return false;
if (type == HighlightInfoType.STATIC_FIELD) return false;
if (type == HighlightInfoType.STATIC_FINAL_FIELD) return false;
if (type == HighlightInfoType.PARAMETER) return false;
if (type == HighlightInfoType.METHOD_CALL) return false;
if (type == HighlightInfoType.METHOD_DECLARATION) return false;
if (type == HighlightInfoType.STATIC_METHOD) return false;
if (type == HighlightInfoType.ABSTRACT_METHOD) return false;
if (type == HighlightInfoType.INHERITED_METHOD) return false;
if (type == HighlightInfoType.CONSTRUCTOR_CALL) return false;
if (type == HighlightInfoType.CONSTRUCTOR_DECLARATION) return false;
if (type == HighlightInfoType.INTERFACE_NAME) return false;
if (type == HighlightInfoType.ABSTRACT_CLASS_NAME) return false;
if (type == HighlightInfoType.ENUM_NAME) return false;
if (type == HighlightInfoType.CLASS_NAME) return false;
if (type == HighlightInfoType.ANONYMOUS_CLASS_NAME) return false;
return true;
}
